Bugs 1888784 and 2032990

An RSS/Atom newsreader with features comparable to commercial newsreaders.
inflector
Muffin
Posts: 42
Joined: Sun Feb 28, 2010 4:59 am

Bugs 1888784 and 2032990

Postby inflector » Sat Mar 06, 2010 9:05 pm

I think that:

Article viewport reset after subscription update - ID: 1888784

After the subscription update completes the article viewport automatically
goes to (0,0), which is quite frustrating because one's place is lost.

I don’t know if there are any pre-conditions; I am using the
‘Condensed’ layout, and this seems to occur with all feeds and styles.


and

Refreshing subscriptions moves current article position - ID: 2032990

When I'm reading an article and Vienna automatically refreshes my
subscriptions, the reader scrolls up to the top as soon as it's done,
losing my place in the article. This is a problem for longer feeds.


are essentially the same bug/feature. This also happens to be a "feature" that bugs me endlessly as it means I can't watch long videos in Vienna without them being reloaded and stopped. So I figured I'd tackle this problem next.

What happens is that when the subscriptions are refreshed the HTML is reloaded into the ArticleView via a call to ArticleView setHTML. Since there may have been changes to an article due to an update of the article with an identical GUID, I'm assuming this was done on purpose. So rather than remove this functionality, I put a simple cache of the last HTML to be placed into the view, if the strings are identical, then setHTML returns before doing anything leaving the existing HTML in place. This fixes both of the above bugs and also doesn't force a reload of videos.

Unless anyone sees a problem with this, I'll send the patch; it's really simple and confined only to ArticleView.h and ArticleView.m.

- Curtis

User avatar
Michael Ströck
Vienna Team
Posts: 303
Joined: Mon Mar 06, 2006 9:21 am
Location: Vienna, Austria
Contact:

Re: Bugs 1888784 and 2032990

Postby Michael Ströck » Sun Mar 07, 2010 9:48 am

Thanks Curtis, looks good. I'll check it in later today.

User avatar
AlanR
Frappa
Posts: 235
Joined: Wed Sep 06, 2006 4:19 am
Contact:

Re: Bugs 1888784 and 2032990

Postby AlanR » Mon Mar 08, 2010 12:11 pm

The Sneak Peek with this fix is up now: http://vienna.mpaka.com


Return to “Vienna”

Who is online

Users browsing this forum: No registered users